Some preliminary issues

[bee-san]

• Add multi threading support
• Create a class structure (turn it into a class or use functions)
• for loop through a wordlist is slow. STEGCRACKER follows this same principle. It's very, very slow and if the password is at the back, it won't work for hours and hours and hours. Here's a better methodology:

Checking for passwords

1. Multi threadding
   Have one start at the back, and one start at the front. Have them both go through the list at the same time, and meet in the middle.
2. Random sampling
   Randomly select chunks of passwords from the list, and assign them to a worker (multi threaded). Make sure to not include those chunks in future workers. This has the benefit that if the password is in the middle, you stand a higher chance of getting it.

I think Rockyou is sorted by frequency (?) so maybe (1) is better.

• use the GPU for hash cracking (difficult but makes it fast)
• Refactor the code (similar to class) so you minimise the amount of code needed.

imo, most of the code should be on on multi threading / grabbing passwords / speed from the dict. If you do these 3 things really, really well then you can still have a very impressive tool while having a small selection of hash crackers. 😄

Overall, really good project. And I love where this is going 😄

Edit: It may be worth it to automatically detect hashes too, instead of passing a type to them. You can do this by checking their length, for example. As all hashes follow strict length guidelines.

[0xblackbird]

Thank you Brandon!

I really appreciate it, without your input I would never know how I would reduce the execution time of the script! Multi-threading was something that I would be adding in the beginning when the tool got released, unfortunatly I got accross some issues which I couldn't fix at that time that's why I left it. But I promise I will add all of the features/functions mentioned above and try to improve the performance of the script!
Cracking hashes using GPU will take some time to implement, but I will get there!
And of course the selection of hash types will grow more and more in the future!

Thank you!