Add a Snackbar notice to inform users that settings have been saved successfully. #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamdharmesh
requested review from
dkotter,
jeffpaul and
a team
as code owners
dkotter
reviewed
Jan 2, 2025
There was a problem hiding this comment.
Overall this works nice and code looks good here. Couple things worth discussing:
- Is it possible to reduce the time the notice shows? Right now the snackbar sticks around for quite a while and I think it would be nice if we could hide it quicker
- This solves success messages but doesn't solve error messages. If you save settings for a Feature and an error occurs, the error shows up top but it is often out of view. Would be great if we scroll to the top when that happens so the error can be seen
|
Note that there's discussion in WP/GB via WordPress/gutenberg#16391 on overall accessibility of the snackbar, so we might perhaps review the consensus from a11y folks there and ensure we utilize the snackbar for error & success states in a solid a11y manner. |
|
Looks like WordPress/gutenberg#67662 is an updated proposal in WP/GB that we might consider here as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR adds a Snackbar notice to inform users that settings have been saved successfully.
Closes #837
How to test the Change
Changelog Entry
Credits
Props @iamdharmesh @dkotter @jeffpaul
Checklist: