Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOM Diffing JavaScript modified content needs to re-run JS init #49

Open
zachleat opened this issue Jan 26, 2023 · 1 comment
Open

DOM Diffing JavaScript modified content needs to re-run JS init #49

zachleat opened this issue Jan 26, 2023 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@zachleat
Copy link
Member

zachleat commented Jan 26, 2023 •
edited
Loading

Workaround for now is to use domDiff: false on projects that do a lot of JS DOM modification.

A few brainstorms:

  1. Add some JavaScript hooks to the live reload client?
  2. Web components will automatically re-init when stuff is re-attached so that may work as-is?

via #7 #39
@zachleat zachleat added bug Something isn't working enhancement New feature or request labels Jan 26, 2023
This was referenced Jan 26, 2023
Closed
Open
@simonpai
Copy link

Is it possible to just perform a full page reload whenever a JavaScript resource gets updated?

Just my 2 cents:

  1. With any JavaScript resource updated a reload is inevitable. Even if there's no error showing up, there's no way to guarantee correctness of the state and this will give us many gotchas.
  2. We may open up a can of worms dealing with Web Components...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zachleat @simonpai