Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page reload websocket connection doesn't use pathPrefix #89

Open
corneyl opened this issue Sep 4, 2024 · 1 comment
Open

Page reload websocket connection doesn't use pathPrefix #89

corneyl opened this issue Sep 4, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@corneyl
Copy link

corneyl commented Sep 4, 2024

We want to use the eleventy dev server behind a reverse proxy, utilising Nginx.

However, the websocket connection, to get notified of changes, always connects to ws://localhost and does not respect the pathPrefix. All other files are served from the pathPrefix path correctly.

What do you think about using the pathPrefix for ws connections as well?
@zachleat
Copy link
Member

zachleat commented Sep 4, 2024

I’d be happy to merge a PR for this!

@zachleat zachleat added the enhancement New feature or request label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zachleat @corneyl