Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate code from openrazer #4

Open
edualm opened this issue May 29, 2021 · 4 comments
Open

Generate code from openrazer #4

edualm opened this issue May 29, 2021 · 4 comments

Comments

@edualm
Copy link
Collaborator

edualm commented May 29, 2021

I've had a go at automatically converting the code from the openrazer code to macOS calls. I think it would be too finicky honestly.

The only reasonable way I see now of automatically using openrazer's code on macOS would be to make the driver itself platform-agnostic which would require upstream changes.

@1kc Do you think this is something we should propose and invest time into, or should we just continue porting changes from openrazer manually? I can create a spike to show the openrazer maintainers a possible way of doing it.

@hacker1024
Copy link

hacker1024 commented May 30, 2021

I think this would be a worthwhile thing - it would make resolving issues like #3 effortless, as well as make it easier to port openrazer to other platforms (I've been considering Android).

@hacker1024
Copy link

This may be a useful reference for a wrapper approach: https://github.com/CalcProgrammer1/openrazer-win32

@edualm
Copy link
Collaborator Author

edualm commented Jul 1, 2021

That's indeed an interesting approach, a shim. Hmm.

@WrathofthePast
Copy link
Contributor

WrathofthePast commented Jan 26, 2022

I have an idea. razerchromacommon.h & razerchromacommon.c are shared between razer-macos and openrazer without modification. We should make those into dependencies. As an added bonus, this will partially resolve #6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants