Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add em support to max and min-width variables #44

Open
anthonyjfio opened this issue Oct 4, 2015 · 2 comments
Open

Add em support to max and min-width variables #44

anthonyjfio opened this issue Oct 4, 2015 · 2 comments

Comments

@anthonyjfio
Copy link

In short what I would like is to set this in the variables

$min-width           = 25em
$max-width          = 50em

and get this in the css file

@media all and (min-width: 25em) {
  . . .
}

I think this could be a great addition, but I'm not sure if it's possible.

Here's the reason why I like to use them http://blog.cloudfour.com/the-ems-have-it-proportional-media-queries-ftw/

@corysimmons
Copy link
Collaborator

Sorry it's taken me so long to respond. I have my ups and downs with being a good maintainer.

I'm planning on migrating this project to PostCSS in the next month or so, and when I do, I'll probably rewrite it from scratch.


Why do you want to get @media all and (min-width: 25em) in particular? You already get @media (min-width: 25em). I don't understand the value of all?

https://github.com/corysimmons/typographic/blob/master/stylus/typographic.styl#L124

@corysimmons
Copy link
Collaborator

I'm also not sure we'll be able to do it, at least not with a lot of extra work. Maybe we can reserve this for a future version of Typographic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants