Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lost-grid compatibility #50

Open
janwirth opened this issue Feb 18, 2016 · 14 comments
Open

lost-grid compatibility #50

janwirth opened this issue Feb 18, 2016 · 14 comments

Comments

@janwirth
Copy link
Contributor

@lost gutter 60px can not be used with vr-block. Makes sense in next version.

@corysimmons
Copy link
Collaborator

You mean accepting vr-block as a value for gutter? Like @lost gutter vr-block; ?

@janwirth
Copy link
Contributor Author

exactly

@corysimmons
Copy link
Collaborator

Will consider it with my new grid and when I'm converting this to PostCSS. I see your point though 👍

@corysimmons
Copy link
Collaborator

I can't remember, is vr-block a function that returns a value?

If so, could you do something like $sass-var: vr-block(); @lost gutter $sass-var;?

@janwirth
Copy link
Contributor Author

Yes. vr-block(2) for example.
I only remember using lost with typographic and stylus where I could not interpolate the variable into the postcss control string if I recall this correctly.

@corysimmons
Copy link
Collaborator

Hmm. Yeah Stylus isn't particularly great at interpolating...

Still though, I'd imagine if you did something like:

$my-var = vr-block(2)

@lost gutter $my-var

And parsed over it with https://github.com/seaneking/poststylus it would work?

@corysimmons
Copy link
Collaborator

Tbh, I'm not sure how to do this otherwise. at-rule settings typically just accept a value. There's no real way to control it on the PostCSS side.

@janwirth
Copy link
Contributor Author

Just mentioning this. Should be no problem in the coming version. Did you create a repo yet?

@corysimmons
Copy link
Collaborator

No, haven't started porting this over yet. Should launch around mid March.

@janwirth
Copy link
Contributor Author

bump

@corysimmons
Copy link
Collaborator

Yeah, I've figured out some really nice vertical rhythm stuff, and even some really nice scaling stuff between headings.

I'm in the process of debating with myself about what I feel about modular scale.... Not particularly sold on it right this second. What do you think about it?

Once I come to a conclusion on that I can start combining all these parts (shouldn't take too long).

@janwirth
Copy link
Contributor Author

It would be much easier for me to articulate my feelings if I knew about the nice stuffs you found! MS seemed solid to me but I don't know about any alternatives. Can you update me?

@corysimmons
Copy link
Collaborator

Note how the headings size in the first pen is related to the $min/max-heading-size settings with steps generated in between.

I dunno... I guess I could do that step thing with modular scale. :\

Maybe it's vertical rhythm I don't like... There's no way to do it correctly. Good looking vertical rhythm seems like a myth that I need to stop screwing around with.

@janwirth
Copy link
Contributor Author

I can not really wrap my head around it right now. I sent you a doc via E-Mail that may help though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants