feature(#1005): Hide or reveal passwords #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
package:kotti-ui
|
I am wondering about why this feature affects all kotti fields, since this feature should only affect KtFieldPassword according to the issue #1005 Wouldn't it be easier to add a boolean field to only KtFieldPassword that lets you opt in (or better opt out) of this toggle. Something like: <!-- Will have the eye icon to toggle the obscure/reveal password -->
<KtFieldPassword />
<!-- Will not have that toggle -->
<KtFieldPassword hideVisibilityToggle /> |
RueRivoli
force-pushed
the
1005-reveal-hide-passwords-option
branch
from
c3c940e to
5f37620
Compare
RueRivoli
force-pushed
the
1005-reveal-hide-passwords-option
branch
from
5f37620 to
a1191a0
Compare
RueRivoli
force-pushed
the
1005-reveal-hide-passwords-option
branch
2 times, most recently
from
ecb3e10 to
cee52f9
Compare
…tField This is needed for KtPassword to reveal/hide passwords to user
RueRivoli
force-pushed
the
1005-reveal-hide-passwords-option
branch
from
cee52f9 to
20779d6
Compare
RueRivoli
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR aims at creating a click handler on KtField right icons so that KtFieldPassword can hide/show password when the user clicks on the eye icon.