refact(kt-field): refact label to reduce field interactivity #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santiagoballadares
added
priority:3-normal
santiagoballadares
force-pushed
the
kt-field-refact-label
branch
5 times, most recently
from
d345f66 to
7f75ae8
Compare
carsoli
reviewed
Dec 7, 2023
carsoli
reviewed
Dec 7, 2023
packages/kotti-ui/source/kotti-field-select/hooks/use-select-tippy.ts
Outdated
Show resolved
Hide resolved
carsoli
reviewed
Dec 7, 2023
packages/kotti-ui/source/kotti-field-select/components/GenericSelectField.vue
Outdated
Show resolved
Hide resolved
carsoli
reviewed
Dec 7, 2023
carsoli
reviewed
Dec 7, 2023
santiagoballadares
force-pushed
the
kt-field-refact-label
branch
3 times, most recently
from
b141e82 to
e7a932a
Compare
|
Duplicated by #851 |
santiagoballadares
force-pushed
the
kt-field-refact-label
branch
2 times, most recently
from
e9b2553 to
b15b7e9
Compare
santiagoballadares
force-pushed
the
kt-field-refact-label
branch
from
b15b7e9 to
b4f7396
Compare
santiagoballadares
force-pushed
the
kt-field-refact-label
branch
2 times, most recently
from
c34daf8 to
9d6200e
Compare
Co-Authored-By: Carol Soliman <[email protected]>
santiagoballadares
force-pushed
the
kt-field-refact-label
branch
from
9d6200e to
33a8f8d
Compare
Isokaeder
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refact
<label />tag to contain onlylabelandoptions/requiredtexts and not the entire field to limit interactivity to the label (optional/required) and the input itself only.