Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(KtFieldToggle/KtFieldSelects/KtFieldDates/KtFieldFileUpload): isLoading edge cases #850

Merged
merged 1 commit into from
Dec 11, 2023
Merged

fix(KtFieldToggle/KtFieldSelects/KtFieldDates/KtFieldFileUpload): isLoading edge cases #850

merged 1 commit into from
Dec 11, 2023

Conversation

carsoli
Copy link
Contributor

@carsoli carsoli commented Dec 5, 2023 •
edited
Loading

  • prevent triggering setValue on isLoading for KtFieldToggle
  • prevent triggering setValue on isLoading for KtFieldDate, KtFieldDateTime, KtFieldDateRange, KtFieldDateTimeRange
  • prevent triggering tippy on isLoading for KtFieldSelect, KtFieldSelectRemote, KtFieldMultiSelect, KtFieldMultiSelectRemote
  • throw on KtField if setValue is triggered while isLoading is true (to guide kotti devs)
  • disable ktFieldUpload(Remote) input natively on isLoading (prevents opening system file explorer)
  • breaking: remove isLoading skeleton margins to avoid weird visual jumping of the field when the isLoading is toggled

@github-actions github-actions bot added the package:kotti-ui @3yourmind/kotti-ui label Dec 5, 2023
@carsoli carsoli changed the title fix(KtFieldToggle/KtField*Select*): isLoading edge cases fix(KtFieldToggle/KtFieldSelects/KtFieldDates): isLoading edge cases Dec 7, 2023
@carsoli carsoli force-pushed the kt-field-add-is-loading-value branch 4 times, most recently from b9076fc to 4ce41c9 Compare December 7, 2023 15:30
FlorianWendelborn
FlorianWendelborn previously approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@FlorianWendelborn FlorianWendelborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/kotti-ui/source/kotti-style/_loadings.scss Show resolved Hide resolved
@carsoli carsoli force-pushed the kt-field-add-is-loading-value branch from 4ce41c9 to ae10ffb Compare December 8, 2023 10:19
@carsoli carsoli enabled auto-merge December 8, 2023 10:19
@carsoli carsoli changed the title fix(KtFieldToggle/KtFieldSelects/KtFieldDates): isLoading edge cases fix(KtFieldToggle/KtFieldSelects/KtFieldDates/KtFieldFileUpload): isLoading edge cases Dec 8, 2023
@carsoli carsoli force-pushed the kt-field-add-is-loading-value branch from ae10ffb to 8ea4286 Compare December 8, 2023 12:19
@carsoli
Copy link
Contributor Author

carsoli commented Dec 8, 2023 •
edited
Loading

@santiagoballadares I will need to test all the skeleton on yoda - would you be able to take over once I publish this and prepare / fix the corresponding changes.. i remove the margin-top and bottom in this MR which will break things (maybe)

@santiagoballadares
Copy link
Collaborator

santiagoballadares commented Dec 8, 2023 •
edited
Loading

FT done

All good, only KtFieldFileUploadRemote needs fixing

Fix for KtFieldFileUploadRemote is now pushed. FT re-done. LGTM

@santiagoballadares
Copy link
Collaborator

@santiagoballadares I will need to test all the skeleton on yoda - would you be able to take over once I publish this and prepare / fix the corresponding changes.. i remove the margin-top and bottom in this MR which will break things (maybe)

@carsoli yes, I can update the Kotti version in Yoda and test

@carsoli @santiagoballadares
fix(KtFieldToggle/KtField*Select*/KtFieldFileUpload*): isLoading edge…
7175b4a 
… cases

    - prevent triggering setValue on isLoading for KtFieldToggle
    - prevent openning tippy on select fields on isLoading
    - prevent openning OS file explorer on file upload fields on isLoading
    - throw on KtField if setValue is triggered while isLoading is true
    - overwrite margin-bottom in KtField
    - change mixin to template and remove margin in _loading.scss

    Co-Authored-By: Florian Wendelborn <[email protected]>
@santiagoballadares santiagoballadares force-pushed the kt-field-add-is-loading-value branch from 2394b9d to 7175b4a Compare December 11, 2023 14:58
santiagoballadares
santiagoballadares approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@santiagoballadares santiagoballadares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carsoli carsoli merged commit 5d10ac4 into master Dec 11, 2023
7 checks passed
@carsoli carsoli deleted the kt-field-add-is-loading-value branch December 11, 2023 15:11
@carsoli
Copy link
Contributor Author

carsoli commented Dec 11, 2023

Tysm @santiagoballadares for taking over 💯

@carsoli carsoli mentioned this pull request Jan 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santiagoballadares santiagoballadares santiagoballadares approved these changes

@FlorianWendelborn FlorianWendelborn FlorianWendelborn left review comments

Assignees
No one assigned
Labels
package:kotti-ui @3yourmind/kotti-ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carsoli @santiagoballadares @FlorianWendelborn