Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(KtField*Select*): Use $props on Template #872

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

FlorianWendelborn
Copy link
Member

@FlorianWendelborn FlorianWendelborn commented Jan 15, 2024

..instead of manually exposing props object

@github-actions github-actions bot added the package:kotti-ui @3yourmind/kotti-ui label Jan 15, 2024
@carsoli carsoli changed the title refactor(KtField*Select*): Use $props on Template Instead of Manually… refactor(KtField*Select*): Use $props on Template Jan 15, 2024
@carsoli
Copy link
Contributor

carsoli commented Jan 15, 2024

This caused issues with Vue 2.7 because reexposing props imploded the template types

@carsoli carsoli force-pushed the naruto/pre-upgrade/prop-erly-use-props branch from 382e228 to 260f96f Compare January 15, 2024 18:20
@carsoli carsoli force-pushed the naruto/pre-upgrade/prop-erly-use-props branch from 260f96f to 260feb3 Compare January 15, 2024 18:21
@carsoli carsoli enabled auto-merge January 15, 2024 18:21
@carsoli carsoli merged commit 9cf2028 into master Jan 15, 2024
7 checks passed
@carsoli carsoli deleted the naruto/pre-upgrade/prop-erly-use-props branch January 15, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:kotti-ui @3yourmind/kotti-ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants