Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): add class to separate flex rows #890

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

carsoli
Copy link
Contributor

@carsoli carsoli commented Jan 18, 2024

#850 caused a UI bug on docs for loadings component, since it removed margin-bottom

introduce a class to add a row-gap between loading skeletons where needed

removal of margin-bottom was intentional

see comments on original PR

@github-actions github-actions bot added the package:kotti-ui @3yourmind/kotti-ui label Jan 18, 2024
@carsoli carsoli force-pushed the fix-margins-on-loading-skeletons branch 2 times, most recently from cd5d693 to 32d15f9 Compare January 18, 2024 11:45
packages/kotti-ui/source/kotti-style/_loadings.scss Outdated Show resolved Hide resolved
@carsoli carsoli force-pushed the fix-margins-on-loading-skeletons branch from 32d15f9 to 85171ee Compare January 18, 2024 11:50
@carsoli carsoli enabled auto-merge January 18, 2024 11:50
@github-actions github-actions bot removed the package:kotti-ui @3yourmind/kotti-ui label Jan 18, 2024
@carsoli
Copy link
Contributor Author

carsoli commented Jan 18, 2024

@FlorianWendelborn need reapproval

@carsoli carsoli merged commit 8f4d8d7 into master Jan 18, 2024
7 checks passed
@carsoli carsoli deleted the fix-margins-on-loading-skeletons branch January 18, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants