Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(split-button): add split button #894

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

santiagoballadares
Copy link
Collaborator

Add new component

  • Change button docs from markdown template to html template
  • Add KtSplitButton to button docs

@santiagoballadares santiagoballadares self-assigned this Feb 20, 2024
@santiagoballadares santiagoballadares force-pushed the add-split-button branch 2 times, most recently from 18e034c to cf1baea Compare February 20, 2024 11:02
@santiagoballadares santiagoballadares marked this pull request as draft February 20, 2024 11:03
@santiagoballadares santiagoballadares force-pushed the add-split-button branch 3 times, most recently from d2251f1 to 9dfedde Compare February 21, 2024 09:10
@santiagoballadares santiagoballadares marked this pull request as ready for review February 21, 2024 09:14
@santiagoballadares santiagoballadares force-pushed the add-split-button branch 2 times, most recently from 5d28716 to ce8981f Compare February 21, 2024 11:26
@Isokaeder
Copy link
Collaborator

Isokaeder commented Mar 13, 2024

For the secondary style, it is strange to me that the divider line between the buttons disappears when hovering the primary button. However, when hovering the secondary button, the primary line persists

Screenshot 2024-03-13 at 21 31 08 Screenshot 2024-03-13 at 21 32 22

Just a tad inconsistent, if you ask me. If design wants that, so be it. But perhaps clarify with them.

@santiagoballadares
Copy link
Collaborator Author

For the secondary style, it is strange to me that the divider line between the buttons disappears when hovering the primary button. However, when hovering the secondary button, the primary line persists

Screenshot 2024-03-13 at 21 31 08 Screenshot 2024-03-13 at 21 32 22
Just a tad inconsistent, if you ask me. If design wants that, so be it. But perhaps clarify with them.

@Isokaeder Design confirmed that this is the desired behavior.

@santiagoballadares santiagoballadares merged commit 2517152 into master Mar 15, 2024
8 checks passed
@santiagoballadares santiagoballadares deleted the add-split-button branch March 15, 2024 09:16
@santiagoballadares santiagoballadares restored the add-split-button branch March 15, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:kotti-ui @3yourmind/kotti-ui priority:3-normal Should be fixed soon type:new-component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants