feat(yoco): add new icons to Yoco #961
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santiagoballadares
added
type:enhancement
…nifying_glass icons - bump version to 2.6.1
santiagoballadares
force-pushed
the
add-various-icons-to-yoco-and-bump-version-to-2.6.1
branch
from
8ae9774 to
3b547f3
Compare
Isokaeder
requested changes
Jul 9, 2024
There was a problem hiding this comment.
We already have an icon search that depicts a magnifying glass, this seems superfluous.
There was a problem hiding this comment.
- Should be called
circle_search - line width of "inner" aka the search/magnifying glass should be slightly smaller, looks weird next to other circle icons. See for example icon
circle_question
santiagoballadares
deleted the
add-various-icons-to-yoco-and-bump-version-to-2.6.1
branch
|
Closed in favor of #964 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add icons:
attention
circle_magnifying_glass
circle_minus
magnifying_glass
bump version to 2.6.1