Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(yoco): add attention, circle_minus, circle_search icons #964

Merged
merged 1 commit into from
Jul 11, 2024
Merged

feat(yoco): add attention, circle_minus, circle_search icons #964

merged 1 commit into from
Jul 11, 2024

Conversation

santiagoballadares
Copy link
Collaborator

@santiagoballadares santiagoballadares commented Jul 10, 2024 •
edited
Loading

add attention, circle_minus, circle_search icons

Screenshot 2024-07-11 at 15 58 41

@santiagoballadares santiagoballadares added type:enhancement features, etc. package:yoco @3yourmind/yoco labels Jul 10, 2024
@santiagoballadares santiagoballadares self-assigned this Jul 10, 2024
FlorianWendelborn
FlorianWendelborn reviewed Jul 10, 2024
View reviewed changes
Copy link
Member

@FlorianWendelborn FlorianWendelborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR LGTM

Did not FT/visually inspect SVGs

@FlorianWendelborn
Copy link
Member

Actually, you may want to bump the yoco version in kotti/documentation/etc. already so that we can enforce minimum versions easier

@github-actions github-actions bot added the package:kotti-ui @3yourmind/kotti-ui label Jul 10, 2024
@santiagoballadares santiagoballadares mentioned this pull request Jul 11, 2024
Closed
@santiagoballadares
Copy link
Collaborator Author

Please refer to discussion in #961

@FlorianWendelborn FlorianWendelborn merged commit 33506be into master Jul 11, 2024
9 checks passed
@FlorianWendelborn FlorianWendelborn deleted the yoco-add-new-icons branch July 11, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianWendelborn FlorianWendelborn FlorianWendelborn left review comments

@Isokaeder Isokaeder Isokaeder approved these changes

Assignees

@santiagoballadares santiagoballadares

Labels
package:kotti-ui @3yourmind/kotti-ui package:yoco @3yourmind/yoco type:enhancement features, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@santiagoballadares @FlorianWendelborn @Isokaeder