generated from chiffre-io/template-library
-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add temporary dedicated server features imports #805
Open
franky47
wants to merge
4
commits into
next
Choose a base branch
from
feat/804-server-imports
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
commit: |
franky47
force-pushed
the
feat/804-server-imports
branch
from
December 14, 2024 09:50
6d868dd
to
29a5b36
Compare
franky47
force-pushed
the
feat/804-server-imports
branch
from
December 27, 2024 10:07
d8489c7
to
729b686
Compare
For some reason, the classic trick of forwarding everything doesn't work under `nuqs/server/*`. We're also removing the temporary imports' `moduleResolution: 'node'` helpers, as v3 will both remove them and require a moduleResolution set to either 'bundler' or 'nodeNext'.
franky47
force-pushed
the
feat/804-server-imports
branch
from
January 1, 2025 10:47
729b686
to
8d07519
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows using the serializer and the parsers (and later on the loaders) in server-side code without depending on React for the cache, as would be the case if importing from
nuqs/server
.🦋 https://bsky.app/profile/francoisbest.com/post/3ld5bqxov722z
X: https://x.com/nuqs47ng/status/1867331081349083400
Tasks
nuqs/server/temporary-react-agnostic
or something)moduleResolution
Note
This PR adds three new imports:
nuqs/server/cache
: exports only the cache feature. Requires React canary (currently only useful in Next.js app router)nuqs/server/parsers
: exports defs & all built-in parsersnuqs/server/serializer
: exports defs & thecreateSerializer
featureThe
nuqs/server
import is untouched in this PR.Future breaking change plans
In nuqs v3:
nuqs/server/cache
will be the only way to import the cache feature, it will be removed fromnuqs/server
nuqs/server/parsers
andnuqs/server/serializers
may be removed for cleanup, as their code will be importable fromnuqs/server
in a framework-agnostic way.Closes #804.
See also discussion #717.