Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Client Hints support #1

Closed
krpn opened this issue Oct 20, 2021 · 3 comments
Closed

Add Client Hints support #1

krpn opened this issue Oct 20, 2021 · 3 comments

Comments

@krpn
Copy link

krpn commented Oct 20, 2021

Please add Client Hints support for Golang.

It's important because we can't detect Windows 11: https://docs.microsoft.com/en-us/microsoft-edge/web-platform/how-to-detect-win11

@jwrosewell
Copy link
Contributor

We’re currently collecting feedback on Go features following the publication of an initial version with support for our V4 C code. The V4 C code supports UACH so it will be a case of exposing the additional functions to Go via CGO. The additional HTTP headers needed are added via fiftyoneDegreesResultsHashFromEvidence. You're welcome to add the necessary CGO code and tests and make a PR against this repo. Also if this is time critical for you then you could consider sponsoring the change. Please contact us if you'd like to follow this route.

@jwrosewell
Copy link
Contributor

Further to the original issue concerning Microsoft's adoption of UACH. The draft report (not a draft specification or on track to become a specification) is still going through important changes with many issues outstanding. We have highlighted this to Microsoft.

@tungntpham
Copy link

Hi @krpn.

We have now released v4.3.2 with support for UACH. Please have a look at the example to see how to enable the UACH support.

Kind regards,
Tung.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants