Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datum Feature not Correct #21

Open
5axes opened this issue Mar 23, 2023 · 0 comments
Open

Datum Feature not Correct #21

5axes opened this issue Mar 23, 2023 · 0 comments
Labels
bug Something isn't working Fixed Fixed in the source code need investigation Need additional information/Sample files or tests to analyse this issue

Comments

@5axes
Copy link
Owner

5axes commented Mar 23, 2023

Datum Feature not Correct

image

Test file :
https://github.com/5axes/FreeCAD-GDT/blob/change-svg-symbol-by-police-symbol/Doc/8x.FCStd

The 8x works fine

image
@5axes 5axes added bug Something isn't working need investigation Need additional information/Sample files or tests to analyse this issue HotFix Must be solved with a Hight Priority labels Mar 23, 2023
5axes added a commit that referenced this issue Mar 23, 2023
@5axes
Change Vertical for DF
f1686cd 
#21
@5axes 5axes mentioned this issue Mar 23, 2023
Merged
5axes added a commit that referenced this issue Mar 23, 2023
@5axes
Change svg symbol by police symbol (#22)
de610c4 
* Add test file

* Update 8x.FCStd

* Update 8x.FCStd

* Change Vertical for DF

#21
5axes added a commit that referenced this issue Mar 23, 2023
@5axes
Change svg symbol by police symbol (#23)
a333248 
* Add test file

* Update 8x.FCStd

* Update 8x.FCStd

* Change Vertical for DF

#21

* Update README.md
@5axes 5axes added Fixed Fixed in the source code and removed HotFix Must be solved with a Hight Priority labels Mar 23, 2023
5axes added a commit that referenced this issue Mar 23, 2023
@5axes
Update Horizontal and Vertical
18e3bc8 
 #21

Code not valid it's just a patch but if the plan is particular it doesn't work
To be reviewed
5axes added a commit that referenced this issue Mar 24, 2023
@5axes
Squashed commit of the following:
25507df 
commit 732145f
Author: 5axes <[email protected]>
Date:   Fri Mar 24 19:42:05 2023 +0100

    update GT

commit 3d0e485
Author: 5axes <[email protected]>
Date:   Fri Mar 24 19:11:48 2023 +0100

    Update Data

    test

commit b110596
Author: 5axes <[email protected]>
Date:   Fri Mar 24 18:14:34 2023 +0100

    Change Groupe

commit 014d6b8
Author: 5axes <[email protected]>
Date:   Fri Mar 24 17:21:36 2023 +0100

    Update GDT.py

commit 352169c
Author: 5axes <[email protected]>
Date:   Fri Mar 24 16:44:48 2023 +0100

    Update Icon

    Test Missing property

commit 8d5c5df
Author: 5axes <[email protected]>
Date:   Fri Mar 24 13:26:53 2023 +0100

    Update README.md

commit 5e5684f
Author: 5axes <[email protected]>
Date:   Fri Mar 24 13:10:23 2023 +0100

    Add new group to get a more logical Structure

    Add Group DS
    and one Groupe by AP

commit 63d19e2
Author: 5axes <[email protected]>
Date:   Fri Mar 24 02:22:42 2023 +0100

    Change the correction for the Geometric Tolerance

commit 18e3bc8
Author: 5axes <[email protected]>
Date:   Thu Mar 23 13:08:29 2023 +0100

    Update Horizontal and Vertical

     #21

    Code not valid it's just a patch but if the plan is particular it doesn't work
    To be reviewed

commit 247a387
Author: 5axes <[email protected]>
Date:   Thu Mar 23 12:36:28 2023 +0100

    Update README.md

commit f1686cd
Author: 5axes <[email protected]>
Date:   Thu Mar 23 12:32:44 2023 +0100

    Change Vertical for DF

    #21

commit 3671178
Author: 5axes <[email protected]>
Date:   Thu Mar 23 11:43:31 2023 +0100

    Update 8x.FCStd

commit bf52a44
Author: 5axes <[email protected]>
Date:   Thu Mar 23 11:38:01 2023 +0100

    Update 8x.FCStd

commit 616373d
Author: 5axes <[email protected]>
Date:   Thu Mar 23 11:36:25 2023 +0100

    Add test file
5axes added a commit that referenced this issue Mar 26, 2023
@5axes
Df group (#27)
324f5b2 
* Add test file

* Update 8x.FCStd

* Update 8x.FCStd

* Change Vertical for DF

#21

* Update README.md

* Update Horizontal and Vertical

 #21

Code not valid it's just a patch but if the plan is particular it doesn't work
To be reviewed

* Change the correction for the Geometric Tolerance

* Add new group to get a more logical Structure

Add Group DS
and one Groupe by AP

* Update README.md

* Update Icon

Test Missing property

* Update GDT.py

* Change Groupe

* Update Data

test

* update GT

* Update With Limit

* Update GDT.py

* Update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Fixed Fixed in the source code need investigation Need additional information/Sample files or tests to analyse this issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@5axes