Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For more security spongycastle -> bouncycastle #1375

Closed
Neustradamus opened this issue Apr 13, 2020 · 7 comments · Fixed by #1772
Closed

For more security spongycastle -> bouncycastle #1375

Neustradamus opened this issue Apr 13, 2020 · 7 comments · Fixed by #1772

Comments

@Neustradamus
Copy link

Neustradamus commented Apr 13, 2020 •
edited
Loading

For more security, can you change old spongycastle (based on old bouncycastle) to bouncycastle?
@t-bast
Copy link
Member

t-bast commented Apr 13, 2020

Thanks for reporting that, I'll have to do some digging, but I believe we needed spongycastle for the android support.
Do you know if that new version of bouncycastle would work on android?
Note that we're only using it for hmac, sha256 and chacha20. Anything related to those in the latest releases?

@Neustradamus
Copy link
Author

@t-bast: Thanks for your comment!
Currently Bouncy Castle last version is 1.65 and Spongy Castle last version is 1.58.
Spongy Castle is a fork of Bouncy Castle.
Please look previous links :)

Since several years, a lot of projects have already moved from Spongy Castle to Bouncy Castle because the project is dead.

You can see discussion "34" in https://github.com/rtyley/spongycastle/issues.

@sstone
Copy link
Member

sstone commented Apr 14, 2020

Yes, we needed to use spongycastle on Android. We're not supporting old versions of Android anymore so it may be possible to switch to BouncyCastle but it is not that obvious even when you look at rtyley/spongycastle#34.

Since several years, a lot of projects have already moved from Spongy Castle to Bouncy Castle

Do you have a list of Android projects that moved from SC to BC ?

@Neustradamus
Copy link
Author

@sstone, @t-bast: Some applications have been noted in the issues.

And a little search here:

@Neustradamus
Copy link
Author

@Any news?

@t-bast
Copy link
Member

t-bast commented Jan 4, 2021

The mobile apps are moving to a new lightning engine in Kotlin, once that's complete we'll be able to update eclair to not depend on spongycastle anymore.

t-bast added a commit that referenced this issue Apr 15, 2021
@t-bast
Use bouncycastle instead of spongycastle
60dbca5 
And reformat files.

Fixes #1375
@t-bast t-bast mentioned this issue Apr 15, 2021
Merged
t-bast added a commit that referenced this issue Apr 21, 2021
@t-bast
Use bouncycastle instead of spongycastle
700b2f2 
And reformat files.

Fixes #1375
t-bast added a commit that referenced this issue Apr 22, 2021
@t-bast
Use bouncycastle instead of spongycastle (#1772)
62dd393 
* Use bouncycastle instead of spongycastle
* Reformat a few files
* Remove wireshark dissector support

Fixes #1375
@Neustradamus
Copy link
Author

@t-bast: Good job, thanks!

At the same time, can you update to 1.69?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use bouncycastle instead of spongycastle ACINQ/eclair
3 participants
@Neustradamus @sstone @t-bast