Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up shared module #106

Closed
kevinwallimann opened this issue Mar 10, 2020 · 1 comment
Closed

Clean up shared module #106

kevinwallimann opened this issue Mar 10, 2020 · 1 comment
Assignees
Milestone

Comments

@kevinwallimann
Copy link
Collaborator

kevinwallimann commented Mar 10, 2020

Currently, not all classes in module shared are really used in multiple modules. With #99 the module needs to be published to maven. To keep its footprint small, only classes whose responsibilities span across multiple modules should be kept in shared. All other classes should be scoped package private on za.co.absa.hyperdrive.

Tasks

  • ConfigurationKeys: Move to ingestor-default package, only move object IngestorKeys to driver module.
  • IngestionException and IngestionStartException: Move to driver module
  • FileUtils, ConfigUtils should be moved to ingestor-default package. Also merge it with the SchemaRegistrySettingsUtil from Add KafkaWriter #108 . They should be made package private on za.co.absa.hyperdrive
  • SparkUtils should be removed since it has no usages. With it, also TestSparkUtils should be removed. Then, the dependency on testutils can be removed. testutils can be removed altogether.
@kevinwallimann kevinwallimann added this to the v3.x.0 milestone Mar 10, 2020
@kevinwallimann kevinwallimann self-assigned this Mar 10, 2020
@kevinwallimann kevinwallimann modified the milestones: v3.x.0, backlog Jun 10, 2020
@kevinwallimann
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant