You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, not all classes in module shared are really used in multiple modules. With #99 the module needs to be published to maven. To keep its footprint small, only classes whose responsibilities span across multiple modules should be kept in shared. All other classes should be scoped package private on za.co.absa.hyperdrive.
Tasks
ConfigurationKeys: Move to ingestor-default package, only move object IngestorKeys to driver module.
IngestionException and IngestionStartException: Move to driver module
FileUtils, ConfigUtils should be moved to ingestor-default package. Also merge it with the SchemaRegistrySettingsUtil from Add KafkaWriter #108 . They should be made package private on za.co.absa.hyperdrive
SparkUtils should be removed since it has no usages. With it, also TestSparkUtils should be removed. Then, the dependency on testutils can be removed. testutils can be removed altogether.
The text was updated successfully, but these errors were encountered:
Currently, not all classes in module shared are really used in multiple modules. With #99 the module needs to be published to maven. To keep its footprint small, only classes whose responsibilities span across multiple modules should be kept in shared. All other classes should be scoped package private on
za.co.absa.hyperdrive
.Tasks
ConfigurationKeys
: Move to ingestor-default package, only move objectIngestorKeys
todriver
module.IngestionException
andIngestionStartException
: Move todriver
moduleFileUtils
,ConfigUtils
should be moved to ingestor-default package. Also merge it with theSchemaRegistrySettingsUtil
from Add KafkaWriter #108 . They should be made package private onza.co.absa.hyperdrive
SparkUtils
should be removed since it has no usages. With it, alsoTestSparkUtils
should be removed. Then, the dependency ontestutils
can be removed.testutils
can be removed altogether.The text was updated successfully, but these errors were encountered: