Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Rails 5 #1737

Closed
mattlindsey opened this issue Jul 17, 2017 · 4 comments
Closed

Update to Rails 5 #1737

mattlindsey opened this issue Jul 17, 2017 · 4 comments
Assignees

Comments

@mattlindsey
Copy link
Collaborator

Update to latest Rails5, currently 5.1.2: http://weblog.rubyonrails.org/2017/6/26/Rails-5-1-2-has-been-released/.

@mattlindsey
Copy link
Collaborator Author

Tried updating Gemfile, running 'bundle update rails' then 'bundle update', but it seems perhaps many gems aren't updated for 5.1.2, or have wrong version numbers:

Bundler could not find compatible versions for gem "railties":
  In Gemfile:
    mercury-rails was resolved to 0.9.0, which depends on
      coffee-rails (>= 3.2.2) was resolved to 4.2.2, which depends on
        railties (>= 4.0.0)

    cucumber-rails was resolved to 1.5.0, which depends on
      railties (< 5.2, >= 4)

    devise was resolved to 4.3.0, which depends on
      railties (< 5.2, >= 4.1.0)

    factory_girl_rails (= 4.5.0) was resolved to 4.5.0, which depends on
      railties (>= 3.0.0)

    factory_girl_rails (= 4.5.0) was resolved to 4.5.0, which depends on
      railties (>= 3.0.0)

    jquery-rails was resolved to 4.3.1, which depends on
      railties (>= 4.2.0)

    jquery-turbolinks (= 2.0.2) was resolved to 2.0.2, which depends on
      railties (>= 3.1.0)

    jvectormap-rails (= 1.0.1) was resolved to 1.0.1, which depends on
      railties (< 5.0, >= 3.1)

    mercury-rails was resolved to 0.9.0, which depends on
      railties (>= 3.0)

    mercury-rails was resolved to 0.9.0, which depends on
      railties (>= 3.0)

    rails (= 5.1.2) was resolved to 5.1.2, which depends on
      railties (= 5.1.2)

    sass-rails was resolved to 5.0.6, which depends on
      railties (< 6, >= 4.0.0)

@mattlindsey
Copy link
Collaborator Author

Getting a little better by replacing jqvmap-rails gem with jvectormap-rails gem:

Bundler could not find compatible versions for gem "activemodel":
  In Gemfile:
    active_model-errors_details was resolved to 1.0.0, which depends on
      activemodel (< 5.0.0.alpha, >= 4.0)

    rails (= 5.1.2) was resolved to 5.1.2, which depends on
      activemodel (= 5.1.2)

    rails (= 5.1.2) was resolved to 5.1.2, which depends on
      activemodel (= 5.1.2)

    rspec-activemodel-mocks was resolved to 1.0.3, which depends on
      activemodel (>= 3.0)

@mattlindsey
Copy link
Collaborator Author

Bundle install now working by removing mercury and active_model-errors_details gems.
So i think now we can proceed to looking at where the tests are failing and try to fix.

@mattlindsey
Copy link
Collaborator Author

Opened issue for 1st error seen when running the site:
activerecord-hackery/polyamorous#23

Looks like polyamorous gem needs some updating for a deprecated method.
If no reply soon, I will try to fix myself and submit PR.

@tansaku tansaku self-assigned this Jul 19, 2017
@tansaku tansaku closed this as completed Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants