Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test case failures in proposals/29:upgrade-9/sanity.test.js #138

Open
LuqiPan opened this issue Apr 3, 2024 · 0 comments
Open

Test case failures in proposals/29:upgrade-9/sanity.test.js #138

LuqiPan opened this issue Apr 3, 2024 · 0 comments
Assignees

Comments

@LuqiPan
Copy link
Contributor

LuqiPan commented Apr 3, 2024

While working on #137, I noticed that we did not set YARN_IGNORE_NODE flag in proposals/29:upgrade-9/test.sh which resulted in yarn ava not running. Setting this flag however, would result in failures in proposals/29:upgrade-9/sanity.test.js.

Fixing these test case failures are outside the scope of #137 so I'm opening an issue to document this and assigning to @turadg who based on git blame created the test file.

PS: for posterity, it would probably be helpful to set -e in proposal/29:upgrade-9/test.sh too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants