Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zoe should have a test of proposalShape. #8606

Open
Chris-Hibbert opened this issue Dec 4, 2023 · 0 comments · May be fixed by #10719
Open

Zoe should have a test of proposalShape. #8606

Chris-Hibbert opened this issue Dec 4, 2023 · 0 comments · May be fixed by #10719
Assignees
@Chris-Hibbert
Labels
enhancement New feature or request triaged_2024 Zoe package: Zoe

Comments

@Chris-Hibbert
Copy link
Contributor

Chris-Hibbert commented Dec 4, 2023 •
edited by gibson042
Loading

What is the Problem Being Solved?

There's no existing test of proposalShape in makeInvitation.

Description of the Design

Write a test. Create a trivial test contract if there's no better place to put it.

Security Considerations

API regression testing is relevant.

Scaling Considerations

None.

Test Plan

#8597 (comment)

  • E(zoe).offer(invitation, badProposal, payments) still creates a seat.
  • getOfferResult() on that seat throws an error complaining about the proposal.
  • The seat's payouts match its payments.

Upgrade Considerations

None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Chris-Hibbert Chris-Hibbert

Labels
enhancement New feature or request triaged_2024 Zoe package: Zoe
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

8606 invite proposals Agoric/agoric-sdk
2 participants
@Chris-Hibbert @aj-agoric