Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make all proposals use tryIstBalances in a3p-integration #10774

Closed
3 tasks done
anilhelvaci opened this issue Dec 26, 2024 · 1 comment · Fixed by #10783
Closed
3 tasks done

make all proposals use tryIstBalances in a3p-integration #10774

anilhelvaci opened this issue Dec 26, 2024 · 1 comment · Fixed by #10783
Assignees
Labels
enhancement New feature or request

Comments

@anilhelvaci
Copy link
Collaborator

anilhelvaci commented Dec 26, 2024

What is the Problem Being Solved?

The nature of how IST fees are charged presents a flakiness in a3p-integartion. See #10565 (comment).

Description of the Design

Iterate over all tests under a3p-integration and switch using tryIstBalances once a test doing otherwise is detected. Address tickets that are already caused by not using tryIstBalances.

Tasks

Preview Give feedback
  1. bug flake test
    Jorge-Lopes anilhelvaci

Open Questions

Do the provisionPool address ever get charged IST execution fee?
This important for us because;

await waitUntilAccountFunded(
PROVISIONING_POOL_ADDR,
ambientAuthority,
{ denom: 'uist', value: istBalanceBefore + 500000 },
{ errorMessage: 'Provision pool not able to swap USDC_axl for IST.' },
);

and

await waitUntilAccountFunded(
PROVISIONING_POOL_ADDR,
ambientAuthority,
{ denom: 'uist', value: istBalanceBeforeLemonsSent + 500000 },
{ errorMessage: 'Provision pool not able to swap USDC_axl for IST.' },
);

Security Considerations

None.

Scaling Considerations

None.

Test Plan

All tests should pass in CI.

Upgrade Considerations

Effects current and future upgrades. New proposals should use tryIstBalances so an effort should be made when reviewing PRs to detect instances where this is not the case.

@anilhelvaci anilhelvaci added the enhancement New feature or request label Dec 26, 2024
@anilhelvaci anilhelvaci self-assigned this Dec 26, 2024
mergify bot added a commit that referenced this issue Dec 26, 2024
closes: #10565
refs: #10774

## Description

Test named `exitOffer tool reclaims stuck payment` was flakey and this prevented landing other PRs like #10530.

### Security Considerations

None.

### Scaling Considerations

None.

### Documentation Considerations

None.

### Testing Considerations

The flakey test was being skipped before. Now we included it back in and the CI should pass.

### Upgrade Considerations

This test concerns current and all future upgrades as the acceptance should pass before landing upgrades.
@anilhelvaci
Copy link
Collaborator Author

anilhelvaci commented Dec 30, 2024

Do the provisionPool address ever get charged IST execution fee?

On a second thought, as long as we don't send any SwingSet transactions from provisionPoolAddress I don't believe the beans will accrue. So I don't think there's anything to worry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant