-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make all proposals use tryIstBalances
in a3p-integration
#10774
Labels
enhancement
New feature or request
Comments
This was referenced Dec 26, 2024
Closed
mergify bot
added a commit
that referenced
this issue
Dec 26, 2024
closes: #10565 refs: #10774 ## Description Test named `exitOffer tool reclaims stuck payment` was flakey and this prevented landing other PRs like #10530. ### Security Considerations None. ### Scaling Considerations None. ### Documentation Considerations None. ### Testing Considerations The flakey test was being skipped before. Now we included it back in and the CI should pass. ### Upgrade Considerations This test concerns current and all future upgrades as the acceptance should pass before landing upgrades.
Do the provisionPool address ever get charged IST execution fee?On a second thought, as long as we don't send any SwingSet transactions from |
anilhelvaci
added a commit
that referenced
this issue
Dec 30, 2024
anilhelvaci
added a commit
that referenced
this issue
Dec 30, 2024
anilhelvaci
added a commit
that referenced
this issue
Dec 31, 2024
anilhelvaci
added a commit
that referenced
this issue
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the Problem Being Solved?
The nature of how IST fees are charged presents a flakiness in
a3p-integartion
. See #10565 (comment).Description of the Design
Iterate over all tests under
a3p-integration
and switch usingtryIstBalances
once a test doing otherwise is detected. Address tickets that are already caused by not usingtryIstBalances
.Tasks
Open Questions
Do the provisionPool address ever get charged IST execution fee?
This important for us because;
agoric-sdk/a3p-integration/proposals/p:upgrade-19/provisionPool.test.js
Lines 107 to 112 in e06691f
and
agoric-sdk/a3p-integration/proposals/p:upgrade-19/provisionPool.test.js
Lines 134 to 139 in e06691f
Security Considerations
None.
Scaling Considerations
None.
Test Plan
All tests should pass in CI.
Upgrade Considerations
Effects current and future upgrades. New proposals should use
tryIstBalances
so an effort should be made when reviewing PRs to detect instances where this is not the case.The text was updated successfully, but these errors were encountered: