Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invoke smart wallet offer result without making a zoe offer #8733

Open
dckc opened this issue Jan 9, 2024 · 1 comment
Open

invoke smart wallet offer result without making a zoe offer #8733

dckc opened this issue Jan 9, 2024 · 1 comment
Labels
enhancement New feature or request performance Performance related issues wallet

Comments

@dckc
Copy link
Member

dckc commented Jan 9, 2024

What is the Problem Being Solved?

pushPrice uses the continuing invitation pattern, which involves getting an invitation from the contract and making an offer via Zoe, when there is no exchange of assets.

Description of the Design

Add an invokeOfferResult(offerId, method, ...args) method to the smartWallet that would

  1. look up the offer result corresponding to offerId
  2. call E(offerResult).method(..args)

The smartWallet's method of choosing of which offerResults to retain might also need adjustment.

Security Considerations

when un-marshaling args, be sure not to create promises (cf. #5965)

Scaling Considerations

The offerId -> offerResult mapping grows without bound. Currently, we consider this manageable because it only occurs for continuing offers:

  • for each vault created - and there's a charge for this
  • for oracle operators
  • for EC members

Test Plan

TBD

Upgrade Considerations

This would be an upgrade to the walletFactory.

@dckc dckc added enhancement New feature or request wallet performance Performance related issues labels Jan 9, 2024
@turadg
Copy link
Member

turadg commented Aug 8, 2024

Relevant discussion:

To put it simply: dapps have all of the domain specific knowledge, but none of the authority, and wallets have all of the authority and none of the domain specific knowledge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request performance Performance related issues wallet
Projects
None yet
Development

No branches or pull requests

2 participants