Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling Label-Triggered Liquidation Tests in PRs #344

Open
rabi-siddique opened this issue Aug 21, 2024 · 0 comments
Open

Handling Label-Triggered Liquidation Tests in PRs #344

rabi-siddique opened this issue Aug 21, 2024 · 0 comments
Labels
bug Something isn't working tooling

Comments

@rabi-siddique
Copy link
Contributor

We've recently added a new capability to run liquidation tests in PRs. Previously, these tests were scheduled to run daily, or you could trigger them manually.

Now, to trigger the end-to-end tests, you need to add specific labels to the PR:

  • Use the liquidation-testing label to trigger tests related to liquidation.
  • Use the liquidation-reconstitution label to trigger tests related to the reconstitution workflow.

While this new feature is helpful, it comes with a challenge. Since these workflows are triggered by labels, they activate whenever a label is added or changed. For example, if you add the liquidation-testing label to run its tests and later decide to test the liquidation reconstitution scenario by adding the corresponding label, this also retriggers the original liquidation tests, causing them to start from scratch.

@rabi-siddique rabi-siddique added bug Something isn't working tooling labels Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tooling
Projects
None yet
Development

No branches or pull requests

1 participant