Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vaults E2E test should indicate mint "exceeds amount available" instead of generic failure #359

Open
0xpatrickdev opened this issue Aug 27, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@0xpatrickdev
Copy link
Member

0xpatrickdev commented Aug 27, 2024

What is the Problem Being Solved?

When running Vaults E2E tests, it can fail if the mint limit is exceeded. It is outside the scope of the test to adjust the mint limit, but we can surface the error earlier. Currently, the test output does not surface a helpful error message and the runner needs to inspect the video artifact.

exceed-amount-avail

Description of the Design

When opening a vault, ensure "Exceeds amount available" text is not on the screen. If it is, fail the test with a message that indicates this specific failure. Currently, timed out retrying after 30050ms: 'cy.click()' failed because this element is 'disabled' is the only clue.

Security Considerations

Test Plan

@0xpatrickdev 0xpatrickdev added the enhancement New feature or request label Aug 27, 2024
@0xpatrickdev
Copy link
Member Author

P.S. the artifact was really helpful here - great idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant