Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TSIP Satellite Check #8

Open
ve7fet opened this issue Jan 31, 2022 · 1 comment
Open

Fix TSIP Satellite Check #8

ve7fet opened this issue Jan 31, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@ve7fet
Copy link
Collaborator

ve7fet commented Jan 31, 2022

In voter.c, process_gps:

if (gps_buf[1] == 0xac) // AC is the Supplemental Timing Packet
{

...

gps_nsat = 3; // Hah, we're faking the number of received sats.

if ((gps_state == GPS_STATE_RECEIVED) && (gps_nsat > 0) && gps_time)
{

Investigate why we're manually setting the number of satellites in view, and see if we can do an actual check from the TSIP string to validate instead.

@ve7fet ve7fet added the bug Something isn't working label Jan 31, 2022
@ve7fet ve7fet self-assigned this Jan 31, 2022
@ve7fet
Copy link
Collaborator Author

ve7fet commented Feb 1, 2022

Looks like TSIP timing packets AB and AC do not actually report number of satellites in view, so that would be why it is manually set.

Will add a note to the source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant