Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$GPGGA Handling #9

Open
ve7fet opened this issue Jan 31, 2022 · 1 comment
Open

$GPGGA Handling #9

ve7fet opened this issue Jan 31, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@ve7fet
Copy link
Collaborator

ve7fet commented Jan 31, 2022

In voter.c, process_gps:

if (strcmp(strs[0],gpgga)) return;

The code following that appears to get the lat/long/alt from the buffer... but it isn't part of a subroutine processing the gpgga string? The if just returns if the string matches gga, without doing anything.

Investigate the handling of that code, and see if it needs to be changed like the other NMEA strings are handled.

@ve7fet ve7fet added the bug Something isn't working label Jan 31, 2022
@ve7fet ve7fet self-assigned this Jan 31, 2022
@ve7fet
Copy link
Collaborator Author

ve7fet commented Jan 31, 2022

Remember to add some comments...

n = atoi(strs[6]); //get the GPS quality indicator from $GPGGA

if ((n < 1) || (n > 2)) //Check for: 1 is GPS Fix, 2 is Diff GPS Fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant