-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for chord display for Ukuleles #18
Comments
Would replacing the |
As far as I understood for now, this is a good option to provide different stringed instruments like Ukulele or Bass. As this libary apparently just provides the visualisation of chords, it's up to Chordreader 2 to provide the chord data base. May be we can use from here . |
Yea ukulele would be awesome! |
@AndInTheClouds has any progress on this been made? I can test the implentation of the suggested library for example. |
Hi CuriousCat42,
I've started making the necessary adaptions and preparations to integrate Ukulele chords. It is one of the next development goals. However, summer time is upcoming an development time rare. So it still may take a while.
Testing will be absolutely appreciated, when it is time to. But if you already would like to contribute, you may search for a comprehensive database or gather different sources of ukulele chords in terms of fret positions and its related fingerings e.g. "C" Chord fret positions 0-0-0-3 with related fingering 0-0-0-1. May be there are also databases containing chord descriptions of the different ukulele tunings: G-Tuning (DGBE), D-Tuning (ADF#B) or Slack-Key Tuning (GCEG), preferably in JSON format or the like. I found similar for guitar on GitHub.
I'm currently investigating the integration of such comprehensive data in the app by keeping performance and less memory consumption also on older devices.
Regards
Am 9. April 2024 14:46:04 MESZ schrieb CuriousCat42 ***@***.***>:
…
@AndInTheClouds has any progress on this been made?
As a noob, may i offer my time (albeit not skill) for any help that may just be tedious or easy to pick up?
I can test the implentation of the suggested library for example.
--
Reply to this email directly or view it on GitHub:
#18 (comment)
You are receiving this because you were mentioned.
Message ID: ***@***.***>
|
I'm also looking forward for this feature. I was just about to propose it. I really love this app and support for ukulele chords display. |
We are almost there. I'm currently implementing it. Some more hours spare time are needed...
Am 27. Juli 2024 18:03:35 MESZ schrieb Florian Henig ***@***.***>:
…I'm also looking forward for this feature. I was just about to propose it. I really love this app and support for ukulele chords display.
--
Reply to this email directly or view it on GitHub:
#18 (comment)
You are receiving this because you were mentioned.
Message ID: ***@***.***>
|
Acceptance criterias
The text was updated successfully, but these errors were encountered: