Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for chord display for Ukuleles #18

Open
wtimme opened this issue Jun 7, 2023 · 7 comments
Open

Add support for chord display for Ukuleles #18

wtimme opened this issue Jun 7, 2023 · 7 comments

Comments

@wtimme
Copy link
Collaborator

wtimme commented Jun 7, 2023

As an Ukulele player,
I want for chords to be displayed for Ukulele,
so that I can tap a chord and know how to play it

Acceptance criterias

  • The display of chords (when tapping a chord) can be configured to be displayed for Ukulele
  • Guitar players are still able to see the guitar chord, if they wish
@wtimme
Copy link
Collaborator Author

wtimme commented Jun 9, 2023

Would replacing the ChordVisualisationView with something like chRyNaN/chords be an option?

First screenshot of the 'chords' library Second screenshot of the 'chords' library

@AndInTheClouds
Copy link
Owner

As far as I understood for now, this is a good option to provide different stringed instruments like Ukulele or Bass. As this libary apparently just provides the visualisation of chords, it's up to Chordreader 2 to provide the chord data base. May be we can use from here .

@joshpetit
Copy link

Yea ukulele would be awesome!

@CuriousCat42
Copy link

@AndInTheClouds has any progress on this been made?
As a noob, may i offer my time (albeit not skill) for any help that may just be tedious or easy to pick up?

I can test the implentation of the suggested library for example.

@AndInTheClouds
Copy link
Owner

AndInTheClouds commented Apr 10, 2024 via email

@florianhenig
Copy link

I'm also looking forward for this feature. I was just about to propose it. I really love this app and support for ukulele chords display.

@AndInTheClouds
Copy link
Owner

AndInTheClouds commented Jul 27, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants