Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance: Store packed block in block_state #1062

Open
heifner opened this issue Dec 11, 2024 · 1 comment · May be fixed by #1148
Open

Performance: Store packed block in block_state #1062

heifner opened this issue Dec 11, 2024 · 1 comment · May be fixed by #1148
Assignees
@heifner
Labels
enhancement New feature or request 👍 lgtm OCI Work exclusive to OCI team
Milestone
Spring v1.2.0-rc1

Comments

@heifner
Copy link
Member

heifner commented Dec 11, 2024

packed_transaction stores both the packed and unpacked transaction for quick access to both forms. The same could be done for block_state for the block.

One area this would help is: #1061 (comment)
Also would make sending out the packed block to net_plugin quicker.
@heifner heifner added the enhancement New feature or request label Dec 11, 2024
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Dec 11, 2024
@heifner heifner changed the title Store packed block in block_state Performance: Store packed block in block_state Dec 11, 2024
@greg7mdp greg7mdp mentioned this issue Dec 11, 2024
Merged
@bhazzard bhazzard added this to the Spring v1.1.0 Cusp milestone Dec 12, 2024
@bhazzard
Copy link

Related to #612 (comment)

@bhazzard bhazzard added 👍 lgtm and removed triage labels Dec 12, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Jan 31, 2025
@heifner heifner self-assigned this Jan 31, 2025
@heifner heifner moved this from Todo to In Progress in Team Backlog Jan 31, 2025
heifner added a commit that referenced this issue Feb 5, 2025
@heifner
GH-1062 Add new datastream_mirror which keeps a copy of the stream da…
4fa1edf 
…ta as it reads.
heifner added a commit that referenced this issue Feb 5, 2025
@heifner
GH-1062 Remove unused read_block_by_id. It did not verify the read bl…
002f31c 
…ock was the correct block id. Not used, so just removed it.
heifner added a commit that referenced this issue Feb 5, 2025
@heifner
GH-1062 Modify signed_block to hold the packed version of the signed_…
0d772f3 
…block so it does not need to be re-packed when needed for the block log or for P2P. Refactor signed_block construction so that it is harder to use incorrectly. It is necessary to always store the packed block in case it is needed. Specialize signed_block unpack so that it always fills in the packed_block of signed_block.
heifner added a commit that referenced this issue Feb 5, 2025
@heifner
GH-1062 Spell out construction desired for gcc
d00a4f7
heifner added a commit that referenced this issue Feb 5, 2025
@heifner
GH-1062 Update test to use create_signed_block
6ae62d8
@heifner heifner linked a pull request Feb 6, 2025 that will close this issue
Open
@heifner heifner moved this from In Progress to Awaiting Review in Team Backlog Feb 6, 2025
heifner added a commit that referenced this issue Feb 6, 2025
@heifner
GH-1062 Add comment
c0b6443
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
enhancement New feature or request 👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Status: Awaiting Review
Milestone
Spring v1.2.0-rc1
Development

Successfully merging a pull request may close this issue.

Performance: Store packed block in signed_block AntelopeIO/spring
3 participants
@bhazzard @heifner @enf-ci-bot