Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHiP: should check last entry's position in log file matches last entry in index file #990

Open
linh2931 opened this issue Oct 30, 2024 · 1 comment
Labels
enhancement New feature or request 👍 lgtm

Comments

@linh2931
Copy link
Member

This is related to test failure 1 of #983

Currently SHiP verifies the number of entries in the index file matches the number of entries in the log file. It does not verifies the value of the last entry's position in log file when validating the last entry.

@bhazzard
Copy link

If they don't match, shutdown with descriptive error message.

@bhazzard bhazzard added 👍 lgtm enhancement New feature or request and removed triage labels Oct 31, 2024
@bhazzard bhazzard added this to the Spring v1.1.0-rc1 milestone Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 👍 lgtm
Projects
Status: Todo
Development

No branches or pull requests

3 participants