Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add selected engine name to QueryAPI.update_cache arguments #1016

Open
fubuloubu opened this issue Aug 27, 2022 · 0 comments
Open

Add selected engine name to QueryAPI.update_cache arguments #1016

fubuloubu opened this issue Aug 27, 2022 · 0 comments
Labels
category: feature New feature or request

Comments

@fubuloubu
Copy link
Member

Overview

It sometimes might be helpful for profiling purposes for a service using an external plugin to have access to what plugin was chosen to provide the result of a data query. In this way, the service might be able to make future decisions on what or how to organize data in order to provide those types of requests more quickly in the future. For example, perhaps the Kerkopes plugin could collect metadata on a query so that it will reorder data available in intermediate cache for quicker response times. This type of data collection should always be optional (I think opt-out is reasonable), but I think it could dramatically improve the QoS that a plugin user might see in certain cases.

Specification

Change to:

def update_cache(self, selected_engine: str, query, data)`

Also, reiterate that all calls to this method should never fail so as not to stop the processing loop in QueryManager from functioning correctly, so all errors should be handled and logged if using this feature in this way to communicate to an external API service.

Dependencies

n/a

@fubuloubu fubuloubu added the category: feature New feature or request label Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant