Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish_build_artifacts.sh returns success even if curl fails #140

Open
davidchau opened this issue Nov 15, 2017 · 1 comment
Open

publish_build_artifacts.sh returns success even if curl fails #140

davidchau opened this issue Nov 15, 2017 · 1 comment
Labels

Comments

@davidchau
Copy link
Contributor

Some releases were not pushed to maven central and we did not get any notification for that.
The reason is publish_build_artifacts.sh script is returning a code 0 even if the curl command did not succeed.

The script must fail in that case.

@davidchau
Copy link
Contributor Author

davidchau commented Nov 30, 2017

This is critical as it can lead to releases not deployed on maven central without the team to notice it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant