Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processing of a file should be based on TMs set up in DB, not provided in a processing request #102

Open
ArchiDevil opened this issue Jan 12, 2025 · 0 comments
Labels
backend Something in a backend bug Something isn't working

Comments

@ArchiDevil
Copy link
Owner

Currently the file processing request requires setting up of TM IDs:

class DocumentProcessingSettings(BaseModel):
    substitute_numbers: bool
    machine_translation_settings: Optional[MachineTranslationSettings]
    memory_ids: list[int] # HERE IS 
    memory_usage: TranslationMemoryUsage
    similarity_threshold: float = Field(default=1.0, ge=0.0, le=1.0)

This is quite weird, because we have a special endpoint to set up things for a document and this request duplicates the code. Even worse, this code on backend does not bind TMs to a document and user is required to set up TMs afterward manually. This must be done using the same endpoint and worker should use IDs from the database, not ones passed within a task.

@ArchiDevil ArchiDevil added bug Something isn't working backend Something in a backend labels Jan 12, 2025
@ArchiDevil ArchiDevil added this to the R9 - Linking things milestone Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Something in a backend bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant