CreationHeight should not be accepted if set Immutable Properties

[0xankit]

It is possible to pass creationHeight as immutables.
CreationHeight should not be accepted if set Immutable Properties.

modules/modules/orders/internal/transactions/make/keeper.go

Lines 55 to 63 in 5571484

	immutableMetaProperties := message.ImmutableMetaProperties.
	Add(baseProperties.NewMetaProperty(constants.ExchangeRateProperty.GetKey(), baseData.NewDecData(message.TakerOwnableSplit.QuoTruncate(sdkTypes.SmallestDec()).QuoTruncate(message.MakerOwnableSplit)))).
	Add(baseProperties.NewMetaProperty(constants.CreationHeightProperty.GetKey(), baseData.NewHeightData(baseTypes.NewHeight(context.BlockHeight())))).
	Add(baseProperties.NewMetaProperty(constants.MakerOwnableIDProperty.GetKey(), baseData.NewIDData(message.MakerOwnableID))).
	Add(baseProperties.NewMetaProperty(constants.TakerOwnableIDProperty.GetKey(), baseData.NewIDData(message.TakerOwnableID))).
	Add(baseProperties.NewMetaProperty(constants.MakerIDProperty.GetKey(), baseData.NewIDData(message.FromID))).
	Add(baseProperties.NewMetaProperty(constants.TakerIDProperty.GetKey(), baseData.NewIDData(message.TakerID)))
	immutables := baseQualified.NewImmutables(baseLists.NewPropertyList(append(immutableMetaProperties.GetList(), message.ImmutableProperties.GetList()...)...))

Solution: CreationHeight should be picked from context everywhere, and in messages we should implement check if creationHeight set or not!

[0xankit]

@deepanshutr

[deepanshutr]

can use mutate method instead of add to avoid this issue