Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding notes when editing songs #387

Open
crowbardoctor opened this issue Nov 30, 2024 · 4 comments
Open

Adding notes when editing songs #387

crowbardoctor opened this issue Nov 30, 2024 · 4 comments

Comments

@crowbardoctor
Copy link

When editing songs in the browser at https://allkaraoke.party/edit/song, it's possible to remove notes or verses. However, is there an option to add new notes or verses instead?

Seems kind of problematic if users can remove notes but not add them.

@Asvarox
Copy link
Owner

Asvarox commented Dec 1, 2024

Hey, thanks for the feedback - this is something I have in mind to do eventually, though it's little priority. The editor in the browser is mostly meant to adjust the songs to YouTube videos which very rarely needs adding new notes.

There are plenty of editors that are capable of various edits in the songs txt https://www.open-music-games.org/play-and-create/song-editors I can add link to it in the editor as a temporary workaround

@crowbardoctor
Copy link
Author

crowbardoctor commented Dec 1, 2024

Hey, thanks for the feedback - this is something I have in mind to do eventually, though it's little priority. The editor in the browser is mostly meant to adjust the songs to YouTube videos which very rarely needs adding new notes.

There are plenty of editors that are capable of various edits in the songs txt https://www.open-music-games.org/play-and-create/song-editors I can add link to it in the editor as a temporary workaround

Thank you for sharing the link; it’s incredibly useful! I wasn’t aware of half of these tools, so I really appreciate it.

I’ve been using Melody Mania as my editor and have uploaded a few songs to the https://allkaraoke.party website. However, I’m still unsure about the process for editing songs after they’ve been uploaded. Do I need to delete a song to properly edit it in an external editor? I assumed this would be necessary, but I’m unable to delete my uploaded songs.

Since there are no user accounts, does the system rely on browser cookies to determine who can delete a song?

@Asvarox
Copy link
Owner

Asvarox commented Dec 2, 2024

So if you opted in for sharing the songs then they are sent over to me as you add them. I briefly review all sent songs and and add them to the main game, so they are accessible to everyone (until I do they're available on your device only).

Once they are added to the main game, they can't be removed - you should be able to download the TXT file of the song, edit it in an external editor and re-add with the import tool. You'll get a warning that there's a duplicate, but you'll be able to go through the wizard anyway and end up overriding the song

This is all good feedback, I haven't thought of such use cases, I'll see how this could be made easier 😄 Thanks!

@crowbardoctor
Copy link
Author

end up overriding the song

Then it's all good, thank you for the quick reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants