Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linking Request improvements #8

Open
2 of 5 tasks
Arrow768 opened this issue Mar 1, 2016 · 1 comment
Open
2 of 5 tasks

Linking Request improvements #8

Arrow768 opened this issue Mar 1, 2016 · 1 comment
Assignees

Comments

@Arrow768
Copy link
Member

Arrow768 commented Mar 1, 2016

This can be improved

  • Check if the byond key in the linking request has played on the server. If not output a error message
  • Display the byond key the linking request has been filed for
  • Add a page that allows users to see their past linking requests
  • Add a page that allows admins to see all linking request (including cancelled ones)
  • Ckey Sanitizing before writing them to the db
@skull132
Copy link
Contributor

Ckeys ought to be sanitized when put into the SQL database, specifically into the ss13_player_linking table.

This would enable me to directly pull linking requests tied to a player by using the client.ckey variable. (By doing something like: SELECT blabla FROM ss13_player_linking WHERE ckey = :client.ckey;) Instead, in order to make the requests not care about user input error, I have to pull all requests that are open, and cycle through them with a while() loop, checking for if (ckey(query.item[1]) == client.ckey). Which is inefficient.

@Arrow768 Arrow768 self-assigned this Mar 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants