-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Ad Code Preview #40
Comments
This would render the ad for preview? |
Yep, that's what I was trying to say. I'll discuss with our designers, let's see what's their take on it. I envision modal window that shows all configured ad tag ids for specific ad code. (like, click preview in row actions, it pops the modal with all the different ad tags) |
Cool, that would be neat. |
this one is mine for 0.4 |
@rinatkhaziev still want to take a swing at this for v0.4? |
@danielbachhuber Is there any tentative release date? |
@carldanley Can you look into this please? I think it'll take less for you time that it would've taken for me. |
Sure, @rinatkhaziev. Is there more information concerning this modal and what it should look like? Has the 'preview' already been added? Just need a little more information to get started. |
No requirements, but what I was envisioning is that when you hit a "Preview" row action it pops up a modal that renders all registered ad sizes. Rendering would happen in AJAX action. If you got a better idea - let's discuss it. |
Will be able to look into this later this month. I'm heads down on a big site launch atm. |
Punting this to v0.5 |
Is there a mockup or anything for this? Was thinking I can use something similar to the new WP modal ( in terms of UI ). Thoughts? |
New WP modal sounds reasonable. There haven't been any mockups afaik On Apr 16, 2013, at 5:11, Carl Danley [email protected] wrote:
|
Yes, there's no mocks. I can ask my UX/UI co-worker, but I agree with wp modal |
This should be probably a row action which either pops an overlay with previews or displays them inline
The text was updated successfully, but these errors were encountered: