Track row actions output on each row to catch cases where custom output ... #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut may not be added When a provider class does not provide a method to output one of its registered columns, our list table should account for the possible lack of row actions. This commit adds a tracking property for the display of row actions. If a column's output is not handled by the provider class and row actions have not yet been displayed, we handle output of the row actions. Once row actions have been output once, the flag is maintained throughout the row. When the row is complete, the flag is reset for the next. One quirk - if a provider class handles the output for the first column, but does not handle row actions, and does not handle the output for the next column, row actions will be output in that second column. This feels a little weird, but I think gets us close enough. Fixes #51
|
This is probably what we want, but should get a second look - @danielbachhuber @rinatkhaziev |
|
This is one hell of a commit message 👍 |
|
Will take a look in the AM, too dumb right now |
ghost
assigned 
|
I'm going to punt this to 0.5-early, so we aren't merging things into v0.4 at the last minute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...may not be added
When a provider class does not provide a method to output one of its registered columns, our list table should account for the possible lack of row actions.
This commit adds a tracking property for the display of row actions. If a column's output is not handled by the provider class and row actions have not yet been displayed, we handle output of the row actions. Once row actions have been output once, the flag is maintained throughout the row. When the row is complete, the flag is reset for the next.
One quirk - if a provider class handles the output for the first column, but does not handle row actions, and does not handle the output for the next column, row actions will be output in that second column. This feels a little weird, but I think gets us close enough.
Fixes #51