Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows 10 compatibility #48

Open
PremyslTalich opened this issue Apr 8, 2024 · 2 comments
Open

Windows 10 compatibility #48

PremyslTalich opened this issue Apr 8, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@PremyslTalich
Copy link

Hello 👋, is the plugin supposed to work under windows? This line seems to break the gradle build as uname is not a Windows command.

my project build.gradle.kts

plugins {
    id("com.automattic.android.measure-builds") version "3.0.0"
}

measureBuilds {
    enable = true
}

The error I got

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring root project 'XXXXX'.
> A problem occurred starting process 'command 'uname''

Thanks for the response

@takahirom
Copy link
Contributor

Ideally, we should have CI testing for Windows.
However, I think it's better to use a try-catch block at least, instead of allowing the program to crash.

@wzieba
Copy link
Member

wzieba commented Apr 15, 2024

hi there @PremyslTalich 👋 Thanks for the report - indeed, the plugin wasn't tested on Windows. We should support this OS as well.

@takahirom good point - I plan to add OS matrix on CI, and it'll be better to have try-catch for this 👍

@wzieba wzieba added the bug Something isn't working label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants