Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crowdsignal Polls Don't Embed #172

Open
sdixon194 opened this issue Aug 22, 2019 · 3 comments
Open

Crowdsignal Polls Don't Embed #172

sdixon194 opened this issue Aug 22, 2019 · 3 comments
Labels

Comments

@sdixon194
Copy link

Issue

When using P2, Crowdsignal polls do not embed at all:

  • When sharing the link, it embeds in the editor, but not the live site. It just has the plain link
  • When using the shortcode, nothing appears on the live site at all

Link sharing gif:

Screen Capture on 2019-08-22 at 13-33-02

Shortcode gif:

Screen Capture on 2019-08-22 at 13-36-02

Expected Behavior

The poll to embed properly on the live post like it does in the editor. This works properly for other themes.

@sdixon194 sdixon194 added the bug label Aug 22, 2019
@lancewillett
Copy link
Contributor

Thanks for reporting this, @sdixon194 — could you please confirm this behavior on various flavors of WordPress?

  1. WordPress.com
  2. Self-hosted WordPress with Jetpack
  3. Self-hosted WordPress without Jetpack

In the case of the first two it'll be likely something to fix on WordPress.com or Jetpack rather than here in the o2 plugin itself, which is largely meant to make the code work well for the 3rd case.

@sdixon194
Copy link
Author

Hey @lancewillett ! Thanks for the quick look - I did some more testing on my self hosted site. When I activate the o2 plugin on either WordPress.com, a self hosted site connected to Jetpack, or a self hosted site with Jetpack disconnected/deactivated, I get the same result.

crowdsignal-nojetpack

The embed seems to work fine with the P2-Oxygen theme on it's own (although the padding leaves a bit to be desired - then again the plugin recommends Genericon'd be installed, which seems to be no longer available):

crowdsignaltest

Let me know if you need me to do any more testing!

@tbradsha
Copy link

tbradsha commented Dec 4, 2019

Confirmed here as well on a WordPress.com (Simple) site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants