Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save button tooltip assumes Mac keyboard #204

Open
Mego opened this issue Nov 29, 2020 · 1 comment
Open

Save button tooltip assumes Mac keyboard #204

Mego opened this issue Nov 29, 2020 · 1 comment

Comments

@Mego
Copy link

Mego commented Nov 29, 2020

Currently, the tooltip for the save button is hardcoded to use the Mac Command key icon (&8984), regardless of the user's environment. A better implementation would be to use the browser's user agent to determine the user's OS (using something like ua-parser-js) and display an appropriate tooltip (Cmd-Enter for Mac OS and iOS, Ctrl-Enter for others).

Parsing OS information from the user agent isn't a perfect solution, but it's the best solution that will work across the vast majority of browser configurations. There is no way to determine if a user agent is accurate for the actual environment, so it will just have to be trusted.

@rfaile313
Copy link
Member

+1 from a sad windows user :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants