Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non FSE themes: changing alignment of image in classic block breaks editing of image #99021

Open
rickmgithub opened this issue Jan 29, 2025 · 3 comments
Labels
[Feature] Core Blocks Blocks that come with Gutenberg. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. Needs triage Ticket needs to be triaged [Pri] Low Address when resources are available. [Product] WordPress.com All features accessible on and related to WordPress.com. [Type] Bug When a feature is broken and / or not performing as intended

Comments

@rickmgithub
Copy link

rickmgithub commented Jan 29, 2025

Context and steps to reproduce

  1. Create a simple site.
  2. Add the Classic theme(Gateway) theme
  3. Create a post
  4. Add a classic editor block
  5. Insert a few paragraphs of text
  6. Click to add an image and save it/publish it
  7. Double click on the image and notice it's editable.
  8. Refresh the page
  9. Now try to the image to the right. Notice you can no longer select the image.

Video -

Screen.Capture.on.2025-01-29.at.16-13-45.mov

Site owner impact

Fewer than 20% of the total website/platform users

Severity

Moderate

What other impact(s) does this issue have?

No revenue impact

If a workaround is available, please outline it here.

No response

Platform

Simple

@rickmgithub rickmgithub added [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Feature] Core Blocks Blocks that come with Gutenberg. [Product] WordPress.com All features accessible on and related to WordPress.com. [Type] Bug When a feature is broken and / or not performing as intended Needs triage Ticket needs to be triaged labels Jan 29, 2025
@github-actions github-actions bot added the [Pri] Low Address when resources are available. label Jan 29, 2025
@Robertght
Copy link

I'm no longer able to replicate this on Simple or AT sites.
I believe this is because of the modal we're displaying instead.

Demo:

bfiSr62PjBpQk3EIjQIqhRiPLbINhwdFb0G6y5f7.mp4

I'm going to mark this as closed for now but please open it again if it's still happening.

@Robertght Robertght added [Closed] Not Reproducible Issue cannot be reproduced. and removed Needs triage Ticket needs to be triaged labels Jan 31, 2025
@Robertght Robertght reopened this Jan 31, 2025
@Robertght Robertght changed the title Changing alignment of image in classic block breaks editing of image Non FSE themes: changing alignment of image in classic block breaks editing of image Jan 31, 2025
@Robertght Robertght added Triaged To be used when issues have been triaged. and removed [Closed] Not Reproducible Issue cannot be reproduced. labels Jan 31, 2025
@matticbot matticbot moved this from Done 🎉 to Triaged in Automattic Prioritization: The One Board ™ Jan 31, 2025
@Robertght
Copy link

I missed an important detail. The theme.

That appears to be the key, so trying this with TwenyTwenty, Gateway or Dara renders the issue above.

I was able to replicate this on Simple and AT sites.

Would this be something fixable within the themes or this a plugin thing?

cc @dsas

@Robertght Robertght moved this from Triaged to In Triage in Automattic Prioritization: The One Board ™ Jan 31, 2025
@Robertght Robertght added Needs triage Ticket needs to be triaged and removed Triaged To be used when issues have been triaged. labels Jan 31, 2025
@dsas
Copy link
Contributor

dsas commented Feb 6, 2025

On a vanilla WordPress, all classic block editing is done within a modal, and things behave as expected. This is both without the GB plugin and with GB 20.2.0. I tested using the Twenty Twenty theme.

On dotcom, both simple and atomic, it doesn't use a modal when using Twenty Twenty or other classic themes, but does when using Twenty Twenty Five.

I can't see anything specific in the Twenty Twenty changelog, and anyway, we're running the most recent version of Twenty Twenty too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Core Blocks Blocks that come with Gutenberg. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. Needs triage Ticket needs to be triaged [Pri] Low Address when resources are available. [Product] WordPress.com All features accessible on and related to WordPress.com. [Type] Bug When a feature is broken and / or not performing as intended
Projects
Development

No branches or pull requests

3 participants