Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Aztec node should throw on an invalid sendTx #10967

Open
spalladino opened this issue Dec 24, 2024 · 0 comments · May be fixed by #10974
Open

chore: Aztec node should throw on an invalid sendTx #10967

spalladino opened this issue Dec 24, 2024 · 0 comments · May be fixed by #10974
Assignees
@spalladino

Comments

@spalladino
Copy link
Collaborator

spalladino commented Dec 24, 2024 •
edited
Loading

When sending a tx that fails validation, sendTx just returns, but doesn't actually send the tx. The client has to find out whether the tx succeeded by querying the tx and seeing it's not actually on the node. We should instead throw on the spot.

While this is an easy change, it breaks pretty much all of our e2e tests, so it'll take time to implement.
@spalladino spalladino self-assigned this Dec 24, 2024
@crStiv crStiv linked a pull request Dec 30, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spalladino spalladino

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(pxe): Add transaction validation check in PXE.sendTx() crStiv/aztec-packages
1 participant
@spalladino