-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed to run tests with flask templates on Windows and Mac #7
Comments
cc @kjaymiller I think we need to ditch pytest-flask given all the issues (and no 3.12 compat) and roll own. The pickle issue is discussed here: pytest-dev/pytest-flask#54 |
We ditched pytest-flask in a recent update to the source. I'll be updating the repos (sadly it's gonna be a manual job). I'll check back in with later today. |
@v-jiaodi Can you see if you are still having issues? We completely changed our local testing approach for Flask and I'm hopeful it'll now work on Windows. |
@pamelafox as I read this, did you mean that it WILL work on Windows? |
Sorry, typo, it was meant to say "now work on Windows", not "not work on Windows". Thanks for clarifying Jay! |
@pamelafox Test again, this issue still exists. |
Can you share the exact error? It should be different since we changed testing package. |
Great, thank you, I am working on a fix. |
@v-jiaodi I have pushed a fix that should hopefully help for Windows, could you pull again and try? |
@pamelafox Test again, the error message is as follows: |
Describe the issue:
When test
Running tests
with flask templates on Windows and Mac, runpython3 -m pytest
, get error as follow:Repro Steps:
python3 -m pip install -r requirements-dev.in
playwright install --with-deps
python3 -m pytest
Environment:
https://github.com/Azure-Samples/azure-flask-postgres-flexible-aca
https://github.com/Azure-Samples/azure-flask-postgres-flexible-appservice
https://github.com/Azure-Samples/azure-flask-cosmos-postgres-aca
https://github.com/Azure-Samples/azure-flask-cosmos-postgres-appservice
https://github.com/Azure-Samples/azure-flask-postgres-addon-aca
https://github.com/Azure-Samples/azure-flask-cosmos-mongodb-aca
https://github.com/Azure-Samples/azure-flask-cosmos-mongodb-appservice
Expected behavior:
Running
python3 -m pytest
with flask templates can pass on Windows and Mac@pamelafox for notification.
The text was updated successfully, but these errors were encountered: