Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Unable to disable prometheus stack on cluster after adding azure container storage extension. #4742

Open
muadnan opened this issue Jan 10, 2025 · 4 comments
Assignees

Comments

@muadnan
Copy link

muadnan commented Jan 10, 2025

Describe the bug
Unable to disable prometheus stack on cluster on which prometheus is already deployed after adding azure container storage extension.

To Reproduce
Steps to reproduce the behavior:

  1. Enable azureContainerStorage extension.
  2. Disable prometheus stack using:
    az k8s-extension update --cluster-type managedClusters --cluster-name <cluster_name> --resource-group <resource_group_name> --name azurecontainerstorage --config base.metrics.enablePrometheusStack=false

Expected behavior
Prometheus stack should be removed and all resources should be deleted including CRD's.

Environment (please complete the following information):

  • CLI Version 2.67.0
  • Kubernetes version 1.31.2

Additional context
There should be an option to disable prometheus stack while enabling azure container storage.

@muadnan muadnan added the bug label Jan 10, 2025
@saurabh0501
Copy link
Contributor

@muadnan , clarifying question - if the above command is being used to disable customer's own Prometheus instance or Azure Container Storage's Prometheus stack? The command is purposed to do the later.

@muadnan
Copy link
Author

muadnan commented Jan 16, 2025

@muadnan , clarifying question - if the above command is being used to disable customer's own Prometheus instance or Azure Container Storage's Prometheus stack? The command is purposed to do the later.

@saurabh0501 The above command is used to disable the kubePrometheusStack deployed by azureContainerStorage as mentioned in the documentation: https://github.com/MicrosoftDocs/azure-docs/blob/main/articles/storage/container-storage/enable-monitoring.md

@muadnan
Copy link
Author

muadnan commented Jan 23, 2025

@muadnan , clarifying question - if the above command is being used to disable customer's own Prometheus instance or Azure Container Storage's Prometheus stack? The command is purposed to do the later.

@saurabh0501 when I changed the config parameter base.metrics.enablePrometheusStack=false it is not actually reflected on the deployed helm release on the AKS. I tried changing other parameter:
base.metrics.metricsExporter.enabled=false
it is working fine. So, there is a bug due to which base.metrics.enablePrometheusStack=false not reflecting on deployed release of azureContainerStorage.

@saurabh0501
Copy link
Contributor

saurabh0501 commented Feb 3, 2025

@olsenme @muadnan, we are currently working on a fix for this issue. We have root-caused the issue, and the fix will be available as part of the Azure Container Storage's next release. I will share more details once I have the plan available for our next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants