Added Support for Azure Machine Learning in Managed Identity #7512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Robbie-Microsoft
requested review from
sameerag,
tnorling,
hectormmg,
peterzenz and
a team
as code owners
There was a problem hiding this comment.
Copilot reviewed 5 out of 9 changed files in this pull request and generated 1 comment.
Files not reviewed (4)
- change/@azure-msal-node-ca262c56-49c0-4e6c-b402-b296b4a10d52.json: Language not supported
- lib/msal-node/src/client/ManagedIdentitySources/ServiceFabric.ts: Evaluated as low risk
- lib/msal-node/test/test_kit/StringConstants.ts: Evaluated as low risk
- lib/msal-node/docs/managed-identity.md: Evaluated as low risk
Comments suppressed due to low confidence (1)
lib/msal-node/src/utils/Constants.ts:12
- [nitpick] The constant name 'MACHINE_LEARNING_AND_SERVICE_FABRIC_SECRET_HEADER_NAME' is too long and unclear. Consider renaming it to 'ML_AND_SF_SECRET_HEADER_NAME'.
export const MACHINE_LEARNING_AND_SERVICE_FABRIC_SECRET_HEADER_NAME: string = "secret";
lib/msal-node/src/client/ManagedIdentitySources/MachineLearning.ts
Outdated
Show resolved
Hide resolved
gladjohn
reviewed
Jan 16, 2025
lib/msal-node/src/client/ManagedIdentitySources/MachineLearning.ts
Outdated
Show resolved
Hide resolved
lib/msal-node/src/client/ManagedIdentitySources/MachineLearning.ts
Outdated
Show resolved
Hide resolved
lib/msal-node/src/client/ManagedIdentitySources/MachineLearning.ts
Outdated
Show resolved
Hide resolved
lib/msal-node/test/client/ManagedIdentitySources/MachineLearning.spec.ts
Outdated
Show resolved
Hide resolved
gladjohn
reviewed
Jan 16, 2025
lib/msal-node/src/client/ManagedIdentitySources/MachineLearning.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Copilot reviewed 5 out of 9 changed files in this pull request and generated no comments.
Files not reviewed (4)
- change/@azure-msal-node-ca262c56-49c0-4e6c-b402-b296b4a10d52.json: Language not supported
- lib/msal-node/src/client/ManagedIdentitySources/ServiceFabric.ts: Evaluated as low risk
- lib/msal-node/src/utils/Constants.ts: Evaluated as low risk
- lib/msal-node/test/client/ManagedIdentitySources/MachineLearning.spec.ts: Evaluated as low risk
Comments suppressed due to low confidence (1)
lib/msal-node/src/client/ManagedIdentitySources/MachineLearning.ts:16
- [nitpick] The constant name ML_AND_SF_SECRET_HEADER_NAME is ambiguous. It should be renamed to MACHINE_LEARNING_SECRET_HEADER_NAME to be more specific.
ML_AND_SF_SECRET_HEADER_NAME
gladjohn
reviewed
Jan 17, 2025
| jest.restoreAllMocks(); | ||
| }); | ||
|
|
||
| test("ensures that App Service is selected as the Managed Identity source when all of its and Machine Learning's environment variables are present", async () => { |
There was a problem hiding this comment.
sorry I am not very familiar with spec.ts, but where do you set MSI_ENDPOINT and MSI_SECRET along with App Service Env Variables but MSAL still picks App Service as MI Source
There was a problem hiding this comment.
search the file for "process.env[".
for example: process.env[ManagedIdentityEnvironmentVariableNames.MSI_ENDPOINT] = "fake_MSI_ENDPOINT";
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7489
Added Machine Learning Managed Identity Source
Tested with unit tests.