Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it a waste of time submitting documentation fixes? #7516

Open
Neutrino-Sunset opened this issue Jan 17, 2025 · 1 comment
Open

Is it a waste of time submitting documentation fixes? #7516

Neutrino-Sunset opened this issue Jan 17, 2025 · 1 comment
Labels
documentation Related to documentation. msal-angular Related to @azure/msal-angular package msal-browser Related to msal-browser package Needs: Attention 👋 Awaiting response from the MSAL.js team public-client Issues regarding PublicClientApplications question Customer is asking for a clarification, use case or information.

Comments

@Neutrino-Sunset
Copy link

Core Library

MSAL.js (@azure/msal-browser)

Wrapper Library

MSAL Angular (@azure/msal-angular)

Public or Confidential Client?

Public

Documentation Location

https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/lib/msal-angular/docs/initialization.md

Description

I submitted a fix for one of your broken documentation examples here

It's been closed by someone who didn't seem to understand the issue, and who is now not responding to comments.

Your guidelines suggest that if we find an issue in the documentation to submit a PR instead of opening an issue, but if this is going to be the response then obviously that's just a waste of time.

@Neutrino-Sunset Neutrino-Sunset added documentation Related to documentation. question Customer is asking for a clarification, use case or information. labels Jan 17, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Awaiting response from the MSAL.js team label Jan 17, 2025
@github-actions github-actions bot added msal-angular Related to @azure/msal-angular package msal-browser Related to msal-browser package public-client Issues regarding PublicClientApplications labels Jan 17, 2025
@CO97
Copy link

CO97 commented Jan 19, 2025

This might have put the final nail in the coffin for this library for me.

The daily frustration I have had since trying to implement this library across multiple Angular applications has been the worst I have ever had. Between the lack off and confusing documents to random nuances between different workflows that are not explained at all.

How the library is intended to be consumed is also not ideal, some random observables to subscribe too put into root levels of the application that perform some magic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation. msal-angular Related to @azure/msal-angular package msal-browser Related to msal-browser package Needs: Attention 👋 Awaiting response from the MSAL.js team public-client Issues regarding PublicClientApplications question Customer is asking for a clarification, use case or information.
Projects
None yet
Development

No branches or pull requests

2 participants