Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laser Shoot on a friend is not seen as a TeamKilled on 2.5 #273

Open
atupone opened this issue Dec 30, 2020 · 1 comment
Open

Laser Shoot on a friend is not seen as a TeamKilled on 2.5 #273

atupone opened this issue Dec 30, 2020 · 1 comment
Labels
Milestone

Comments

@atupone
Copy link
Contributor

atupone commented Dec 30, 2020

Tested on ratnets with solo bots.
After being killed they do not rejoin

@atupone atupone added the bug label Dec 30, 2020
@atupone atupone added this to the 2.6 Release milestone Dec 30, 2020
@atupone
Copy link
Contributor Author

atupone commented Jan 5, 2021

It seems that, in certain circumstances, AddShot is called after the Msg Kill.
My guess is that, especially with Laser, the MsgKill is detected locally (by solo bot) and sent to the server immediately, and may arrive before the shot message is sent.
Both messages are sent to the server on two different tcp connection so the ordering is not guaranteed.

I am thinking about two solutions to this:

  1. Send the MsgFireShot to the server, reply the message to the client, and detect the kill based on the server reply
  2. Remove the check on the shot ID

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant